This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Old skill tester: Fix Padatious setup and fallback intents #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken when Padatious moved from a separate "skill" into the service manager. This updates the code to call the correct methods
|
Voight Kampff Integration Test Succeeded (Results) |
Codecov Report
@@ Coverage Diff @@
## dev #2894 +/- ##
=======================================
Coverage 52.59% 52.59%
=======================================
Files 123 123
Lines 10989 10989
=======================================
Hits 5780 5780
Misses 5209 5209 Continue to review full report at Codecov.
|
Previously this was just skipped over but is now needed for the fallback intents
This will handle any extra messages after the skill complete message was detected. For example messages from certain fallback skills
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
approved these changes
May 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was broken when Padatious moved from a separate "skill" into the
service manager. This updates the code to call Padatious through the intent service. Resolves initial description in #2893.
The old skill tester didn't support
wait_for_response()which hindered the fallback service to function, this PR includes a commit adding a basic implementation for this.In addition some extra handling of the queue was needed to make sure that the events emitted in the fallback handler were handled before considering the skill to be completely handled.
How to test
Run
./bin/mycroft-skill-testrunner /opt/mycroft/skills/mycroft-stop.mycroftai/for example and make sure the skill test launches.fallack-query can be used to check a fallback skill.
Contributor license agreement signed?
CLA [ Yes ]