Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Upgrade requests to 2.25.1 #2783

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Upgrade requests to 2.25.1 #2783

merged 2 commits into from
Mar 15, 2021

Conversation

PureTryOut
Copy link
Contributor

Description

Upgrades requests to 2.25.1

How to test

Run the unit tests.
Verify with a clean installation that all things that get downloaded still work, and network connectivity is still correct.

Contributor license agreement signed?

CLA [x]

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Dec 19, 2020
@JarbasAl
Copy link
Contributor

cant this be relaxed? some other package/skill will eventually require a lower requests version

i would say the version should be lowered not increased, and versions should be pinned with >= not ==

this is a cleanup that should be done across all requirements imho

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

@krisgesling
Copy link
Contributor

I think we need a broader discussion on how these should be handled. In the past we've had things randomly break from newer package incompatibility so I'm not sure that I'm keen on open ended >= definitions.

It does seem like we could allow flexibility within known working minor versions, eg: requests>=2.20.0,<2.26.0

Given we have the testing in a much better place now, we should also be able to do this in a more automated fashion, testing new dependency versions as they're released against not just core, but all Skills (and in future plugins) in the Marketplace.

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling merged commit 458d566 into MycroftAI:dev Mar 15, 2021
@PureTryOut PureTryOut deleted the upgrade/requests branch March 15, 2021 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants