This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Ensure messagebus is connected before reporting that the service is ready #2758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to new standard method to connect to bus client Ensure exceptions during .run() are raised to the Enclosure service Add missing .stop() method to base Enclosure Class Shift call of .stop() to after exit signal
1 task
|
Voight Kampff Integration Test Succeeded (Results) |
ken-mycroft
approved these changes
Dec 30, 2020
| @@ -128,7 +131,6 @@ def handle_gui_status_request(self, message): | |||
|
|
|||
| def send(self, msg_dict): | |||
| """ Send to all registered GUIs. """ | |||
| LOG.info('SENDING...') | |||
|
Voight Kampff Integration Test Failed (Results). |
1 similar comment
|
Voight Kampff Integration Test Failed (Results). |
|
Voight Kampff Integration Test Succeeded (Results) |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.run()are raised to the Enclosure service.stop()method to base Enclosure Class and shift the call of it to after exit signalTo add:
How to test
Start Mycroft and check that the bus is connected before the service reports ready.
Contributor license agreement signed?