This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Fix Voight kampff reset of patched config #2742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I read more of the context I see that there may be a better way of handling this. Adding the work in progress label while I research a bit more. |
|
Voight Kampff Integration Test Succeeded (Results) |
|
Thanks for digging into this, and also for not just removing the logging line 😂 |
original_config will now only live in the scenario part of the context being automatically cleared at the end of each scenario. To reset the patch a custom cleanup is added when the patch is performed.
Since we have a reset log a matching info message for when updating the config should be shown
4f420c6 to
dfe909a
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
|
Updated the procedure to use a custom cleanup. This keeps all the config logic in a single location and fixes the redundant config patch clearing. |
krisgesling
approved these changes
Nov 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resets a configuration patch by adding a custom cleanup function. This moves the entire config patching and resetting into the steps/configuration.py file keeping it all together in one place.
This also fixes issue with test cases following a case setting the system units would reset the config despite not needing to. This resulted in quite cluttered see here for example
How to test
Make sure VK test passes and reset message is only shown on test cases that patches the config.
Contributor license agreement signed?
CLA [ Yes ] (Whether you have signed a CLA - Contributor Licensing Agreement