Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Conversation

joshuajaharwood
Copy link
Contributor

@joshuajaharwood joshuajaharwood commented Sep 27, 2020

Description

Partially fixes #2700. Allows specifying an engine in Polly TTS configuration to be passed to boto3 when synthesising speech.

How to test

Add a value under key tts.polly.engine in user config. This can be done using mycroft-config edit user. The values should either be standard or neural.

Example user config

"tts": {
    "module": "polly",
    "polly": {
      "voice": "Amy",
      "region": "eu-west-2",
      "access_key_id": "placeholder",
      "secret_access_key": "placeholder",
      "engine": "neural"
    }
  }

Caveats

This doesn't add support for conversational speech as specified in #2700, my understanding of SSML is currently too limited for me to do so.

Contributor license agreement signed?

@devops-mycroft devops-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Sep 27, 2020
@devops-mycroft
Copy link

Hello, @joshuajaharwood, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

@krisgesling
Copy link
Contributor

Hey, thanks for this. Having a quick look at the boto3 docs this all seems correct.

Let me know if you have any trouble with the CLA process.

As SSML is detected for each phrase and the text-type is set dynamically, to add support for their conversational / newscaster speaking style we'd need to make sure it handled both phrases that contained other SSML, and phrases that were plain-text. But that can wait for another day.

PS: Ignore the failed test, it's an unrelated issue I need to fix.

@krisgesling krisgesling added the Type: Enhancement - proposed New proposal for a feature that is not currently a priority on the roadmap. label Sep 28, 2020
@joshuajaharwood
Copy link
Contributor Author

Still waiting on contact to sign the CLA.

@krisgesling
Copy link
Contributor

There must be an issue with the CLA form as you're the second in a few days to have this issue.

While I get that fixed up, can you email me at kris.gesling@mycroft.ai so I have the right email address to send it to?

Thanks

@joshuajaharwood joshuajaharwood marked this pull request as ready for review October 4, 2020 15:00
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Oct 5, 2020
Copy link
Contributor

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I've updated the docs, thanks again :)

@krisgesling krisgesling merged commit 7bd0e25 into MycroftAI:dev Oct 5, 2020
@joshuajaharwood joshuajaharwood deleted the feat/issue-2700 branch October 5, 2020 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Type: Enhancement - proposed New proposal for a feature that is not currently a priority on the roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: Enhance Amazon Polly support
3 participants