Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Bugfix/issue 2563 #2692

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Bugfix/issue 2563 #2692

merged 3 commits into from
Sep 22, 2020

Conversation

katridi
Copy link
Contributor

@katridi katridi commented Sep 12, 2020

Description

#2563 If there is no path e.g. ~/mycroft/mycroft-core/mycroft/client/speech/recognizer/model/WRONG-PATH/hmm
then created en-us config

How to test

run PocketSphinxRecognizerTest.testRecognitionFallback

Contributor license agreement signed?

CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Sep 12, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

forslund
forslund previously approved these changes Sep 16, 2020
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works just as expected 👍. I wonder if the LOG statement should be extended to say somehing like "Falling back to en-us" in addition to the model not found just for clarity.

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@katridi
Copy link
Contributor Author

katridi commented Sep 16, 2020

Yeah, sure i can add it, it would definitely clarify this behaviour

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

1 similar comment
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling
Copy link
Contributor

Awesome, thanks for another great PR, and to Ake for the review 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Type: Bug - complex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants