This repository was archived by the owner on Sep 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Bugfix/issue 2563 #2692
Merged
Merged
Bugfix/issue 2563 #2692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voight Kampff Integration Test Failed (Results) |
forslund
previously approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works just as expected 👍. I wonder if the LOG statement should be extended to say somehing like "Falling back to en-us" in addition to the model not found just for clarity.
Voight Kampff Integration Test Succeeded (Results) |
Yeah, sure i can add it, it would definitely clarify this behaviour |
Voight Kampff Integration Test Failed (Results) |
1 similar comment
Voight Kampff Integration Test Failed (Results) |
Voight Kampff Integration Test Succeeded (Results) |
forslund
approved these changes
Sep 21, 2020
Awesome, thanks for another great PR, and to Ake for the review 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA: Yes
Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Type: Bug - complex
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2563 If there is no path e.g.
~/mycroft/mycroft-core/mycroft/client/speech/recognizer/model/WRONG-PATH/hmm
then created
en-us
configHow to test
run
PocketSphinxRecognizerTest.testRecognitionFallback
Contributor license agreement signed?
CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement