This repository was archived by the owner on Sep 8, 2024. It is now read-only.
initialize status members before bus handlers #2681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Voight Kampff Integration Test Succeeded (Results) |
|
Looks good, not already included in #2648 so will merge after the 20.08 release. |
|
It is included in #2648 since the new ProcessStatus class declares the state before registering the handlers (which replaces these handlers) |
self._loaded_status was accessed from a message handler, if a message is received at the precisely wrong time an exception may occur. This fixes the init order. Also moves the skill_updater creation to be fore the handlers are registered.
c9a8093 to
b71bedd
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
|
I've updated this with a possible fix for another issue flagged by @j1nx, it now creates the skill_updater object before registering the bus handlers. I'm not quite sure in which scenario this would make a difference but should be more correct. |
krisgesling
approved these changes
Sep 14, 2020
|
Just saw that I missed merging this after the 20.08 release. Thanks again :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
self._loaded_status was accessed from a message handler, if a message is
§received at the precisely wrong time an exception may occur. This fixes
the init order.
This was reported by @j1nx with the following stack trace:
In this case it was likely a message from mycroft gui that arrived at precisely the wrong time.
The issue is likely resolved in #2648, but if that PR isn't included this is a quick fix for the issue.
Contributor license agreement signed?
CLA [ Yes ]