This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Don't reload skill if a mod time is in the future #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Voight Kampff Integration Test Failed (Results) |
20b7b0b to
305fc88
Compare
|
Voight Kampff Integration Test Failed (Results) |
305fc88 to
bb144d4
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
bb144d4 to
35b2291
Compare
This stops a skill from being reloaded repeatedly if a file gets a bad modification time. It also logs the offending files in the error message.
35b2291 to
10092c3
Compare
|
Rebased and conflicts from #2662 has been resloved. |
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
approved these changes
Sep 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This stops a skill from being reloaded repeatedly if a file gets a bad
modification time. Should resolves #2656
It also logs the offending files in the error message.
How to test
Modify the modtime of a file in a skill to a future time
for example
touch -d "now + 30 minutes" __init__.pyMake sure that the skill isn't reloaded and that the Error message is shown exactly once specifying the correct file.
then set the change time to a valid time
touch __init__.pyand make sure the file is reloaded.
Contributor license agreement signed?
CLA [ Yes ]