This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Refactor wake-word waiting and record phrase #2589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb39ab2 to
d3d48be
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
chrisveilleux
suggested changes
May 20, 2020
53ec1b0 to
e8b0399
Compare
|
I think I've handled most of the comments here. I'm investigating if there's a small logic issue. Feel free to re-review but don't merge just yet |
|
Voight Kampff Integration Test Succeeded (Results) |
e8b0399 to
45bbc0a
Compare
|
Did find and correct a small logic thing when checking the sentence completion, it was missing a check for the 0.25 sec of quietness. |
|
Voight Kampff Integration Test Succeeded (Results) |
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
- Add RollingMean data structure - Add simple CyclicBuffer data structure - Move out post find actions into separate method
- Return the data from the wakeword as a tuple. - Extract post wakeword actions from wait for wakeword method
Move wakeword duration to the wakeword engine since all wakeword engines doesn't really use phonemes
The function is based on the parameters of the Mic and is much more a method of the mic than a static function
_record_phrase now uses a helper class to track the noise in a sentence to determine when the user has stopped speaking. The logic should be the same but the same but allow for easier testing and manipulation.
45bbc0a to
926d3ff
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
chrisveilleux
approved these changes
May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The wake-word waiting and record phrase methods mixed a lot of logic with maths and were reported as high complexity methods, this separates the math out from the methods keeping the logic.
How to test
Check that unit tests all pass and that Mycroft can still wakeup and process audio.
Contributor license agreement signed?
CLA [ Yes ]