Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

CI: Reduce Jenkins reporting verbosity #2568

Closed
wants to merge 1 commit into from
Closed

CI: Reduce Jenkins reporting verbosity #2568

wants to merge 1 commit into from

Conversation

forslund
Copy link
Collaborator

@forslund forslund commented May 6, 2020 •
edited
Loading

Description

  • E-mails are only sent on failing branch builds
  • PR comment is only sent on failure

The rationale here is that the build status is available from github so sending success emails / PR comments provides no extra useful information. A failure however is more likely to need immediate response from the PR author. Branch build failures will be reported by e-mail to the dev-team so these things can be caught quickly. This mirrors the behavior of Travis and PEP8-speaks.

See this test run for an example of e-mail notifications still being sent on failure.

Contributor license agreement signed?

CLA [ Yes ]

@forslund
Reduce Jenkins reporting verbosity
989adb0 
- E-mails are only sent on failing branch builds
- PR comment is only sent on failure
@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label May 6, 2020
@forslund forslund changed the title Reduce Jenkins reporting verbosity CI: Reduce Jenkins reporting verbosity May 6, 2020
@krisgesling
Copy link
Contributor

This would be my preferred reporting level personally. Though currently I just filter all the success emails, so doesn't bother me a great deal.

For PR's, if it fails, anyone subscribed to that thread will be notified, hence prompts the author to take another look. If it succeeds, no new message required as the expectation is already for pull requests to get reviewed.

For branch builds, if it fails, get emailed and go investigate what's gone wrong.

If there's disagreement still, we could get some feedback from the community on how they'd like it.

@forslund
Copy link
Collaborator Author

forslund commented Jun 2, 2020

I think what we agreed on on last time we discussed this was to always send an email to dev@mycroft.ai and I neede to update this PR to reflect that before it's good to merge.

@krisgesling krisgesling added the Status: Work in progress PR being actively worked on, not yet ready for review. label Jul 23, 2020
@krisgesling krisgesling added the Type: Enhancement - roadmapped Implementation of a feature that is a priority on the roadmap. label Sep 24, 2020
@krisgesling krisgesling mentioned this pull request Jul 9, 2021
Merged
@forslund
Copy link
Collaborator Author

forslund commented Sep 8, 2024

Closing PR since we're archiving the repo

@forslund forslund closed this Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krisgesling krisgesling Awaiting requested review from krisgesling

@chrisveilleux chrisveilleux Awaiting requested review from chrisveilleux

Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Status: Work in progress PR being actively worked on, not yet ready for review. Type: Enhancement - roadmapped Implementation of a feature that is a priority on the roadmap.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forslund @krisgesling @devs-mycroft