This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Fix uploading settings meta #2543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the order so the started flag is set before the settingsmeta the send() method is called. The send() method now exits if the started flag isn't set causing the skill settings not to be uploaded
5bc8c85 to
d1b6db3
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
approved these changes
Apr 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the order so the started flag is set before the settingsmeta
the send() method is called.
The send() method now exits if the started flag isn't set causing the
skill settings not to be uploaded.
The issue was introduced in PR #2529 when adding the possibility to stopping the upload loop.
How to test
Startup mycroft-core and check the skills log so that settingsmeta are uploaded.
Contributor license agreement signed?
CLA [ Yes ]