Hello, @luca-vercelli, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

Voight Kampff Integration Test Succeeded (Results)

Hello @luca-vercelli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-15 10:47:49 UTC

Voight Kampff Integration Test Succeeded (Results)

Tested it with swedish and works great!

I had one thought when viewing it offline, it might be cleaner to have the language change done in the __init__() instead of every time a sentence is parsed:

The __init__() would become

    def __init__(self, lang, config):                                           
        super(GoogleTTS, self).__init__(lang, config, GoogleTTSValidator(       
            self), 'mp3')                                                       
        langs = tts_langs()                                                     
        if self.lang.lower() not in langs:                                      
            if self.lang[:2].lower() in langs:                                  
                self.lang = self.lang[:2]                                       
            else:                                                               
                raise ValueError("Language not supported by gTTS: {}"           
                                 .format(self.lang))

What do you think?

I agree, you are right.
Moreover, I have just seen a method "validate_lang" a few lines below... with a "TODO" annotation... maybe that's the right place to put the code?

Voight Kampff Integration Test Succeeded (Results)

Hmmm, not sure really, the "validate" in the method name indicates that it is a check and should not do any modifications.

I would split it up and do the modification in the __init__() or set to None if no lang can be determined. Then raise the exception in the validate_lang method.

Voight Kampff Integration Test Succeeded (Results)

Voight Kampff Integration Test Failed (Results)

CLA received, but looks like this may still be in progress.

Voight Kampff Integration Test Succeeded (Results)

I think this looks good, I'll rebase it and squash the pep8 / typo fixes into their parent commits to make the commit history cleaner and then I'll merge it.

Voight Kampff Integration Test Succeeded (Results)