Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Fix danish typos and better translations #2520

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Fix danish typos and better translations #2520

merged 2 commits into from
Mar 31, 2020

Conversation

andlo
Copy link
Contributor

@andlo andlo commented Mar 29, 2020

Description

This PR fixes some typos and make better translations. Should only be changes in /mycroft-core/mycroft/res/text/da-dk

How to test

Change to danish on mycroft and hear better language :)

Contributor license agreement signed?

CLA [X ] (Whether you have signed a CLA - Contributor Licensing Agreement

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Mar 29, 2020
@forslund
Copy link
Collaborator

Looks good, thanks @andlo. seems like a change to .gitignore was included in the PR, we could keep it but it would be best if we could separate it out in a separate commit since it has nothing to do with the language update. I could handle it for you if you like.

@andlo
Copy link
Contributor Author

andlo commented Mar 30, 2020

Ohh I am sorry - i added .theia to the .gitignire just like .vscode is. I tryed to remove it and then I did my faivorite stunt by dooing lots of github mess :( Sorry, but I am not good at githubing.....

@forslund
Copy link
Collaborator

We can definitely include the theia folder in the .gitignore but it should not be included in the same commit as the language since it's a completely different issue. This looks good. Will be merging shortly

@forslund forslund merged commit 918c98f into MycroftAI:dev Mar 31, 2020
@andlo andlo deleted the bugfix/danish-translations branch March 31, 2020 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants