This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Feature/timing out of thread #2481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a05fd53 to
be80162
Compare
chrisveilleux
approved these changes
Feb 25, 2020
Sets up a thread with a queue interface to handle the upload of timing information to the backend. Previously this was done in the emitter thread after a skill or subsystem had delivered their content to avoid slowing down the system. However massively parallell calls like the "mycroft.stop" message would starve the threadpool casuing the upload time to limit the execution speed of these.
be80162 to
ef76f68
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a thread pool starvation issue when reporting metrics. Previously this was done in the emitter thread after a skill or subsystem had delivered their content to avoid slowing down the system. However massively parallell calls like the "mycroft.stop" message would starve the threadpool causing the upload time to limit the execution speed of these.
This also limits the number of listeners to the "mycroft.stop" message to those who actually implements a stop method.
How to test
Make sure the news skill is played correctly on this branch and make sure stop stops the playback as expected
Contributor license agreement signed?
CLA [ Yes ]