This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Simplify the converse callings #2479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce0eacb to
c86c4f9
Compare
chrisveilleux
approved these changes
Mar 3, 2020
Remove the use of the separate error message and use the wait_for_reply method to get the converse result. The error message is left to guarantee compatibility.
c86c4f9 to
58f0ac8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the separate error message and use the wait_for_reply method to
get the converse result. This removes a lot of the old logic for handling the waiting for a response.
How to test
Make sure things such as get_response (install/remove skills)
Contributor license agreement signed?
CLA [ Yes ]