Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Conversation

FruityWelsh
Copy link
Contributor

==== Related Issues ====
Alternative triggers. #1357 - Added feature to activate via command line
This can be triggered in most desktop enviroments via short cuts

==== Tech Notes ====
Copied mycroft-speak-to format, just it doesn't need any cl option
and replaced the bus message with "mycroft.mic.listen" message.

==== Documentation Notes ====
Activates the mycroft listening feature.

On branch feature/mycroft-listen_cli_tool
Changes to be committed:
new file: mycroft-listen

Description

(Description of what the PR does, such as fixes # {issue number})

How to test

(Description of how to validate or test this PR)

Contributor license agreement signed?

CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement

==== Related Issues ====
Alternative triggers. MycroftAI#1357 - Added feature to activate via command line
This can be triggered in most desktop enviroments via short cuts

====  Tech Notes ====
Copied mycroft-speak-to format, just it doesn't need any cl option
and replaced the bus message with "mycroft.mic.listen" message.

====  Documentation Notes ====
Activates the mycroft listening feature.

 On branch feature/mycroft-listen_cli_tool
 Changes to be committed:
	new file:   mycroft-listen
@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jan 22, 2020
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well, thank you.

Just a couple of nitpicks, the year in the license should be 2020 now and, if you agree, replace the storing output in the output variable with a redirect to /dev/null

@forslund
Copy link
Collaborator

Hi, will you be pushing an update along the lines we discussed earlier?

@FruityWelsh
Copy link
Contributor Author

FruityWelsh commented Feb 3, 2020

Hi, will you be pushing an update along the lines we discussed earlier?

So I am having some issues actually pushing this change.

I manged to update to the dev branch, but my actually changes:
# Copyright 2020 Mycroft AI Inc.
and
python -m mycroft.messagebus.send "mycroft.mic.listen"
don't seem to pushing when I edit them, do git add . and git push my-mycroft-repo.

Which is odd as git pull upstream dev and git push my-mycroft-repo did work...

Edit:
I forgot to commit lol ...

@ChanceNCounter
Copy link
Contributor

I forgot to commit lol ...

Welcome to my life!

@forslund
Copy link
Collaborator

forslund commented Feb 4, 2020

Thanks @FruityWelsh, merging now.

@forslund forslund merged commit 389c7dc into MycroftAI:dev Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants