This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Add tzinfo to extracted datetime #2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I set my Mycroft device and OS time to the KC timezone then the Alarm Skill tests pass on the current dev branch. If I only set my device time but not my OS time to the KC timezone then the tests still fail on this bugfix branch. So I'm assuming that some datetimes are being extracted from the device settings, and some from the system clock? |
dcc5898 to
9d8f81d
Compare
This will provide timezone info as well as now reference to the extracted sentences.
9d8f81d to
9c8c8e0
Compare
|
I've updated with a correct(-er) approach, sending a now reference to lingua-franca. Tested this with the alarm skill using various device times (Hawaii, Kansas City, CET, Darwin (before and after midnight over there) |
|
Thank goshness |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lingua-franca returns the extracted datetime without the datetime from
the device info. This needs to be added by core through an "anchorDate" specifying the current time (including timezone info).
How to test
Set your timezone to Kansas City run the skill tester for the latest alarm skill version and assure the tests passes.
Contributor license agreement signed?
CLA [ Yes ]