Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Conversation

forslund
Copy link
Collaborator

@forslund forslund commented Jan 18, 2020

Description

Time has come (or is quite overdue) to update to the latest pip version. The reasons for keeping a locked pip version is that pip historically a pip version update has broken the dev-setup a number of times.

Fixes #2456.

How to test

Make sure a new venv can be built without issues and Mycroft can be run.

Contributor license agreement signed?

CLA [ Yes ]

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jan 18, 2020
@opensource-assist
Copy link

I believe that forward compatibility is a lot more important than backward compatibility, because you're never gonna transition to the past.

@forslund
Copy link
Collaborator Author

We do try to keep up with the latest python releases but we do need to try to keep things stable and not bleeding edge to maintain production quality and user experience.

@opensource-assist
Copy link

opensource-assist commented Jan 22, 2020

@forslund

We do try to keep up with the latest python releases but we do need to try to keep things stable and not bleeding edge to maintain production quality and user experience.

I see. just merge it.

@krisgesling
Copy link
Contributor

I did an almost clean install on Debian 10, and it seems to be working fine.

I see 20.0.1 got released after this PR was made, should we bump straight to that?
Once we confirm the version to update to I'll test it across all platforms.

Also, this is outside scope of this change, however:
I left my Skills directory in place but because I was working from a fresh venv many Skill dependencies weren't installed. Wondering if we should be checking Skill requirements in case it is a "re-installation" rather than completely fresh install?

@opensource-assist it is tempting to just update everything to the latest version, but a lot of people use Mycroft on a daily basis and they understandably would get pretty frustrated if everything stops working because we haven't taken the time to test things properly. The good thing about open source is that you are free to fork it and run everything on the bleeding edge :)

@forslund
Copy link
Collaborator Author

I'll update to 20.0.1 and see that it works.

There are (or at least were) a check in msm to "re-pip" (as it was known) on updates if a new venv is in place. Possibly dev_setup.sh should remove the .msm file to directly trigger an update or maybe dev_setup should run a msm update?

@forslund
Copy link
Collaborator Author

@krisgesling switched it to 20.0.1 seems to be working just as well...

@forslund
Copy link
Collaborator Author

Bumped it one more time to 20.0.2 lets hope it's stable now.

@krisgesling
Copy link
Contributor

20.0.2 is also working fine for me

@forslund
Copy link
Collaborator Author

Then let's merge this :)

@forslund forslund merged commit a83a794 into MycroftAI:dev Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to run on Python3.9
5 participants