Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Conversation

forslund
Copy link
Collaborator

Description

Verifies that resources are read from both locale and dialog folders. Also checks that fallbacks to en-us from other languages works as expected.

How to test

Check that Travis tests passes.

Contributor license agreement signed?

CLA [ Yes ]

@pep8speaks
Copy link

pep8speaks commented Dec 29, 2019

Hello @forslund! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-29 13:25:57 UTC

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Dec 29, 2019
@forslund forslund force-pushed the test/translate-methods branch from 386a84a to 80f8904 Compare December 29, 2019 13:23
Verifies that resources are read from both locale and dialog folders.
Also checks that fallbacks to en-us from other languages works as
expected.
@forslund forslund merged commit 3f11e8f into MycroftAI:dev Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants