This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Add setting for padatious single_thread in mycroft.conf #2448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andlo, looks nice and simple! If you fix the pep8 issues we can merge this afterwards. |
|
Thanks @andlo. Looks great. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make it posible to use remote debugging there is need for at setting to turn off and on singlethread in padatious. This I think were done best by a mycroft.conf setting.
When (if) this is merged I have a remote-debug skill that uses PTVSD to enable remote debug :)
How to test
Change setting for padatious single_thread in mycroft.conf and see that it changes how padatios run.
Se in log that single_thread is true or fals acording to setting in mycroft.conf
Contributor license agreement signed?
CLA [ x ] (Whether you have signed a CLA - Contributor Licensing Agreement