Prepare for gTTS 2.1.0 #2447
Prepare for gTTS 2.1.0 #2447
Conversation
Signature of gTTS.__init__ changes in 2.1.0 and breaks calls with
unnamed arguments like gTTS('some text', 'de')
|
Hello, @ansgar-t, thank you for helping with the Mycroft project! We welcome everyone To protect yourself, the project, and users of Mycroft technologies we require Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank |
|
changelog here for reference https://github.com/pndurette/gTTS/blob/master/CHANGELOG.rst |
|
Thanks @ansgar-t Looks good. I'll do a verification test on Monday and if nothing weird pops up I'll merge this when the CLA is completed. Is there any reason to not upgrade gTTS to 2.1.0? |
Not that I know of. Just wanted my first PR here to be 100% safe :) |
|
Tested and works as expected. When the CLA has been completed we'll merge it. Thanks for the contribution! |
|
Thanks Ansgar! |
Signature of gTTS.init changes in 2.1.0 and breaks calls with
unnamed arguments like gTTS('some text', 'de')
Description
I upgraded my local mycroft installation to gTTS 2.1.0 because I wanted a bugfix from there.
This broke GoogleTTS because of the usage of unnamed arguments and a signature change in gTTS. Technically, this is not a mycroft issue (yet), so I did not create an issue here.
Please note, that this (rather trivial) PR only adds the names to some arguments. It does NOT include the upgrade to gTTS 2.1.0.
How to test
No changed functionality, so only regression testing for google TTS?
Unit tests are successful locally - except for one that seems to assume configuration of 'en-us'.
Not sure, how to run the integration tests, though.
Manually tested that Google TTS works with both, gTTS 2.0.4 and 2.1.0.
(Without this fix, it will fallback to English with gTTS 2.1.0, even if German is configured.)
Contributor license agreement signed?
CLA [ ]
(not yet, waiting for response...)