This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Refactor mycroft.dialog #2422
Merged
Refactor mycroft.dialog #2422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function replaces the class since the class doesn't provide any functionality
bba6219 to
7b90e99
Compare
|
ping @chrisveilleux |
- Move code out of __init__.py - Correct spacing of docstrings - Make use of ' uniform - Add module level docstring
The DialogLoader class has been replaced by the simpler load_dialogs function.
7b90e99 to
f759903
Compare
chrisveilleux
approved these changes
Feb 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
__init__.pyto a dialog.pyShould this still exist as a mycroft.dialog module in the long term? It's quite a small but provides one of the core features of mycroft. With #2436 it's likely to grow in complexity so it may have some merit to keep it as it is.
How to test
Make sure tests pass and that skills can speak responses still.
Contributor license agreement signed?
CLA [ Yes ]