This repository was archived by the owner on Sep 8, 2024. It is now read-only.
mark1/fix display big images #2429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have been having trouble with things not rendering in the faceplate, after a lot of frustration after some digging i found this
https://github.com/MycroftAI/enclosure-mark1/blob/master/protocols.txt#L141
according to the spec there is a bug, i have not tested this however (mark1 is not dev friendly!)
i have a game of life skill and some other goodies waiting on this :)
NOTE: pr made directly in browser, sorry if something is messed up