Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Conversation

JarbasAl
Copy link
Contributor

i have been having trouble with things not rendering in the faceplate, after a lot of frustration after some digging i found this

https://github.com/MycroftAI/enclosure-mark1/blob/master/protocols.txt#L141

according to the spec there is a bug, i have not tested this however (mark1 is not dev friendly!)

i have a game of life skill and some other goodies waiting on this :)

NOTE: pr made directly in browser, sorry if something is messed up

@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Dec 17, 2019
@forslund
Copy link
Collaborator

I tried this on the device but it doesn't improve I'm afraid :(

Looking at the enclosure code here, it seems like the $ needs to be at the end of the code.

It could be the way the code is cut...looks like the second part gets very close to 64 character limit.

@JarbasAl
Copy link
Contributor Author

i have finally tested this on my mark1, it does not work with or without this change

this still makes things according to the spec i linked, so at least that needs to be updated

i think it makes more sense like in the spec than like it is coded in your link, so which one should be changed?

more importantly, how do we fix the actual bug?

@forslund
Copy link
Collaborator

Like you I do think the approach with the $ sign in the beginning is better.

it also adds the possibility for some sanity checks

  • if end of code is $ copy code and offsets to storage variables
  • if starts with $
    • case 1 buffer with store exists, concatenate with stored buffer and reset buffer.
  • case 2 the store is missing, drop current message
  • if a message without $ first or last arrives reset the storage buffer

Then it does look like the $ aren't stripped from the code when storing the first part of the message (here) which may be the problem.

@forslund
Copy link
Collaborator

Did a quick test of the first part of how it handles the $-sign in the first part: https://gist.github.com/forslund/f4fb0698ed508b6db553ea2b153bd34a

@JarbasAl JarbasAl mentioned this pull request Mar 2, 2020
@forslund forslund merged commit 05cae9d into dev Mar 6, 2020
@forslund forslund deleted the bug/mark1_faceplate branch March 26, 2020 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Type: Bug - complex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants