Fix - Filter by Price block slider doesn't use theme accent color in LTR language
#2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
approved these changes
May 5, 2025
There was a problem hiding this comment.
Thanks for working on this, @amitraj2203! I see the PR is instead in Draft, but I tested it and it looks as expected on my end:
| Before | After |
|---|---|
Are there any other changes you would like to do or we can go ahead and merge? 🙂
Testing environment
- WordPress 6.8 local dev environment
- Plugins: WooCommerce Beta Tester
- Theme: Storefront
- Store creation: April 24th 2025
- Store size: small
|
@Aljullu Thanks for the review! I’ve just marked the PR as ready for review 🙂 |
|
Thanks! Great job, @amitraj2203! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2185
This PR fixes an inconsistency in how the
Filter by Priceblock's slider color is applied in the Storefront theme. Currently, the slider correctly uses the theme's accent color in RTL mode but fails to apply it in LTR mode, resulting in an inconsistent user experience when switching between languages.The solution increases the CSS selector specificity by adding the tag name div to the selector, ensuring the accent color is properly applied in both LTR and RTL modes. This fix maintains the existing behavior for RTL languages while correcting it for LTR languages.
Screenshots
How to test the changes in this Pull Request:
Filter by PriceandProduct CollectionblocksChangelog