Fix double synchronization of transaction log + integrity checks #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## stable #912 +/- ##
==========================================
+ Coverage 95.34% 95.36% +0.01%
==========================================
Files 167 167
Lines 10159 10195 +36
==========================================
+ Hits 9686 9722 +36
Misses 473 473
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Fixes a critical bug that caused transaction log corruption due to double synchronization in the Drop implementation. The PR removes the problematic Drop implementation and adds integrity validation to detect broken replication logs early.
Key changes:
- Removed the Drop implementation from TransactionLog that was causing double synchronization
- Added comprehensive integrity checks to validate transaction log state during loading
- Updated function signature to accept path by reference instead of ownership
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| reductstore/src/replication/transaction_log.rs | Removed Drop implementation, added integrity validation, changed path parameter handling |
| reductstore/src/replication/replication_task.rs | Updated to handle integrity check failures with fallback log recreation |
| reductstore/src/replication/replication_sender.rs | Updated function call to match new signature |
| CHANGELOG.md | Added entry for the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What was changed?
Patch #909 caused corruption of the transaction log due to double synchronization in the Drop implementation. The PR removes the Drop implementation and adds an integrity test to detect broken replication at the beginning. This may help to understand how the log breaks in #898.
Related issues
#909
#898
Does this PR introduce a breaking change?
No
Other information: