Prevent data lost of unsynchronized files in case of power failure for unfinished blocks #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## stable #909 +/- ##
==========================================
- Coverage 95.36% 95.34% -0.03%
==========================================
Files 167 167
Lines 10102 10159 +57
==========================================
+ Hits 9634 9686 +52
- Misses 468 473 +5
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements file synchronization to prevent data loss during power failures for unfinished blocks. The solution adds periodic syncing functionality to the file cache to ensure data integrity.
- Adds a background sync worker that periodically syncs open write files every 100ms
- Implements sync-on-eviction for files being removed from the cache
- Extends the cache with iterator functionality to support the sync operations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| reductstore/src/core/file_cache.rs | Main implementation of sync worker, file sync logic, and cache eviction handling |
| reductstore/src/core/cache.rs | Adds iterator support for the sync worker to iterate over cached files |
| CHANGELOG.md | Documents the bug fix for preventing data loss during power failures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #904
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What was changed?
The file cache is now responsible for synchronizing files with the disk to prevent data loss in the event of a power failure.
The File Cache synchronizes all files that are open for writing:
Related issues
Does this PR introduce a breaking change?
No
Other information: