Skip to content

feat: allow to add address name for xpub children #10393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

feat: allow to add address name for xpub children #10393

merged 2 commits into from
Aug 7, 2025

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 32.35294% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.33%. Comparing base (190e415) to head (059affe).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...p/src/components/accounts/AccountBalancesTable.vue 28.12% 23 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #10393      +/-   ##
===========================================
+ Coverage    49.27%   49.33%   +0.05%     
===========================================
  Files         2074     2074              
  Lines       149011   149038      +27     
  Branches     15220    15224       +4     
===========================================
+ Hits         73432    73522      +90     
+ Misses       73011    72948      -63     
  Partials      2568     2568
Flag Coverage Δ
frontend_integration 52.50% <36.84%> (+0.50%) ⬆️
frontend_unit 29.30% <23.52%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kelsos
Copy link
Member

kelsos commented Aug 6, 2025

@lukicenturi is this to edit the labels for the xpub sub addresses?

I tried and changing works but it does not show you the previous label to edit

@lukicenturi lukicenturi force-pushed the add-xpub-address-names branch from 11bb736 to 059affe Compare August 7, 2025 04:39
@lukicenturi
Copy link
Contributor Author

@lukicenturi is this to edit the labels for the xpub sub addresses?

I tried and changing works but it does not show you the previous label to edit

should be fixed now

kelsos
kelsos approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine lgtm thank you @lukicenturi

@kelsos kelsos merged commit f9b36e3 into rotki:develop Aug 7, 2025
16 checks passed
@kelsos kelsos deleted the add-xpub-address-names branch August 7, 2025 07:54
@kelsos kelsos temporarily deployed to cassette-merge August 7, 2025 07:54 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelsos kelsos kelsos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukicenturi @kelsos