Skip to content

connection: Call newPathManagerOutgoing only once per conn #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

connection: Call newPathManagerOutgoing only once per conn #5279

wants to merge 1 commit into from

Conversation

MarcoPolo
Copy link
Collaborator

Noticed this in passing. The compare and swap operation does not do what the comment suggests. Example https://play.golang.com/p/S7dTJ9Pek4W

This is one solution that does what the comment wanted, an alternative is to do something like:

old := ptr.Load()
if old == nil {
  v := init()
  ptr.CompareAndSwap(nil, v)
}

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2298 1 2297 3
View the top 3 failed test(s) by shortest run time 
github.com/quic-go/quic-go/integrationtests/self::TestHandshakeWithPacketLoss/drop_1/3_of_packets_in_Outgoing_direction/retry:_false/server_speaks_first
Stack Traces | 124s run time 
Failed
github.com/quic-go/quic-go/integrationtests/self::TestHandshakeWithPacketLoss/drop_1/3_of_packets_in_Outgoing_direction/retry:_false
Stack Traces | 125s run time 
Failed
github.com/quic-go/quic-go/integrationtests/self::TestHandshakeWithPacketLoss/drop_1/3_of_packets_in_Outgoing_direction
Stack Traces | 128s run time 
Failed

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann Awaiting requested review from marten-seemann

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarcoPolo