ackhandler: check for missing packets below reordering treshold #5260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR makes the reordering threshold in the ACK handler configurable and updates the missing‐packet detection logic accordingly, along with test refactors for stability and a new packet‐history method.
- Introduce
reorderingThresholdconstant and adjusthasNewMissingPacketslogic to account for it - Replace the old
GetHighestAckRangeAPI withHighestMissingUpTo, initializedeletedBelow, and update tests for that change - Refactor tests to use a fixed
nowtimestamp instead of multipletime.Now()calls
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/ackhandler/received_packet_tracker.go | Added reorderingThreshold const and updated hasNewMissingPackets to use it |
| internal/ackhandler/received_packet_tracker_test.go | Refactored loops and consolidated timestamps in tests (introduced loop syntax bugs) |
| internal/ackhandler/received_packet_history.go | Initialized deletedBelow and implemented HighestMissingUpTo in place of old API |
| internal/ackhandler/received_packet_history_test.go | Updated tests to call HighestMissingUpTo and changed loop constructs (bugs) |
Comments suppressed due to low confidence (3)
internal/ackhandler/received_packet_tracker_test.go:58
- The loop syntax
for range 2is invalid in Go. Replace it with a standard index loop, for example:for i := 0; i < 2; i++ {.
for range 2 {
internal/ackhandler/received_packet_tracker_test.go:62
- The loop syntax
for range 3is invalid in Go. Use an index-based loop instead, like:for i := 0; i < 3; i++ {.
for range 3 {
internal/ackhandler/received_packet_history_test.go:184
- You cannot
rangeover an integer. Change to an index loop, for example:for i := 0; i < num; i++ {.
for i := range num {
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #5260 +/- ##
==========================================
+ Coverage 84.30% 84.39% +0.09%
==========================================
Files 154 154
Lines 17635 17654 +19
==========================================
+ Hits 14866 14898 +32
+ Misses 2206 2196 -10
+ Partials 563 560 -3 ☔ View full report in Codecov by Sentry. |
No functional change expected. With the Acknowledgement Frequency extension, the reordering threshold will become configurable. With this change, it will be easy to use the peer-requested value instead of the predefined constant.
079e36d to
8832b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change expected.
For #2482.
With the Acknowledgement Frequency extension, the reordering threshold will become configurable. With this change, it will be easy to use the peer-requested value instead of the predefined constant.