congestion: limit pacing events to 64 per RTT to reduce timer frequency #4931
+63
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the minimum pacing delay is 1ms. If the bandwidth allows sending more frequently, we instead release a batch of packets into the network every 1ms. Additionally, we now also limit the number of pacing events to 64 per RTT, i.e. apply a minimum pacing delay of 1/64 RTT. This allows us to arm the pacing timer less frequently, while still achieving most of the benefits of packet pacing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4931 +/- ##
=======================================
Coverage 83.76% 83.76%
=======================================
Files 152 152
Lines 16272 16275 +3
=======================================
+ Hits 13629 13632 +3
Misses 2121 2121
Partials 522 522 ☔ View full report in Codecov by Sentry. |
|
Something is wrong with this PR. It completely kills transfer performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the minimum pacing delay is 1ms. If the bandwidth allows sending more frequently, we instead release a batch of packets into the network every 1ms.
Additionally, we now also limit the number of pacing events to 64 per RTT, i.e. apply a minimum pacing delay of 1/64 RTT. This allows us to arm the pacing timer less frequently, while still achieving most of the benefits of packet pacing.