Return query vector #5778
Open
Return query vector #5778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mubelotix
commented
Aug 6, 2025
|
I previously wanted to only return the query vector when it was embedded locally, not when it was provided as-is in the request, but that was too complex. It's much more reliable to always return the query vector (when |
irevoire
requested changes
Aug 7, 2025
There was a problem hiding this comment.
Huu, I think you were not supposed to push this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #5779
What does this PR do?
When
retrieveVectorsis true, search should also return the vector of the query if it was embedded automatically.