Use new @geneontology/web-components package on ribbon sandbox and COVID-19 pages
#772
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the GO ribbon implementation by replacing the legacy @geneontology/wc-ribbon package with the new @geneontology/web-components package. The changes update component names, remove manual data fetching, and improve the styling and layout across three key pages.
Key changes:
- Replace old web component elements with new standardized ones (
<wc-go-ribbon>→<go-annotation-ribbon>,<wc-ribbon-strips>→<go-annotation-ribbon-strips>) - Remove manual API data fetching logic that was causing loading issues on the COVID-19 page
- Update documentation to reference the new component package and documentation site
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ribbon.html | Updates ribbon sandbox page with new web component and improved responsive layout |
| js/ribbon.js | Adds clearRibbon function for the updated ribbon interface |
| js/covid.js | Removes manual data fetching logic and simplifies ribbon initialization |
| covid-19.html | Replaces old ribbon components with new ones and removes unused styling |
| _sass/custom/_typography.scss | Adds btn-no-radius CSS class for button styling |
| _includes/head.html | Adds script tag to load the new web-components package |
| _docs/ribbon.md | Updates documentation to reference new package and removes outdated technical details |
Comments suppressed due to low confidence (1)
@geneontology/web-components package on ribbon sandbox and COVID-19 pages
There was a problem hiding this comment.
A refresh on the GO website to use the ribbon refresh as part of the new unified repository.
@pkalita-lbl I was pondering whether we should always be adding the instruction to follow the go-technical-announcements repository to follow, updates, roadmaps changes, formats, EoL announcements, etc. I'm still a little worried that we get uptake and then pull the rug out from under people? But then again, this is not a well trafficked page and this update is still better than the old wc-ribbon...
|
Talking to @pkalita-lbl , I think this is a great PR and can be merged at convenience. |
Fixes #771
These changes replace the old
@geneontology/wc-ribbonpackage with the new@geneontology/web-componentspackage. The changes affect three pages:Ribbon Sandbox (https://geneontology.org/ribbon)
<wc-go-ribbon>element with new<go-annotation-ribbon>element.Ribbon docs page (https://geneontology.org/docs/ribbon.html)
COVID-19 page (https://geneontology.org/covid-19.html)
<wc-ribbon-strips>element with new<go-annotation-ribbon-strips>element.